Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roll deployments #141

Closed
wants to merge 1 commit into from
Closed

roll deployments #141

wants to merge 1 commit into from

Conversation

s1ntaxe770r
Copy link

fixes #97

@s1ntaxe770r
Copy link
Author

using the rollme annotation described in the helm docs. Wasn't sure what file the deployment should depend on?

blacksails
blacksails suggested changes Sep 27, 2023
View reviewed changes
deploy/charts/rig/templates/deployment.yaml
@@ -11,6 +11,8 @@ spec:
matchLabels: {{ include "rig.selectorLabels" . | nindent 6 }}
template:
metadata:
annotations:
rollme: {{ randAlphaNum 5 | quote }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

randAlphaNum sucks with gitops, please do shasum of the rendered config secret.

@blacksails
Copy link
Contributor

Closing this. Feel free to reopen if you have a fix.

@blacksails blacksails closed this Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacksails blacksails blacksails requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use helm trick to roll deployment on config changes
2 participants
@s1ntaxe770r @blacksails