Skip to content

Conversation

@tomasherceg
Copy link
Member

@tomasherceg tomasherceg commented Jul 12, 2024

DataPager did not have a way to provide custom templates for page numbers, and there was no way to apply CSS classes or other attributes on inner <li> and <a> / <span> elements.

However, there is a bug here - when I use ListItemClass instead of ListItemclass, the attribute is rendered as Class and is not combined with Knockout JS binding css: { "class": something }.

It can be reproduced in ControlSamples/DataPager/DataPagerTemplates sample by changing the casing.

@tomasherceg tomasherceg marked this pull request as draft July 12, 2024 20:51
@tomasherceg tomasherceg force-pushed the feature/datapager-templating branch from 67b4d47 to 8c6e824 Compare August 1, 2024 19:31
@tomasherceg tomasherceg force-pushed the feature/datapager-templating branch from 8c6e824 to d7c726c Compare September 1, 2024 15:54
@tomasherceg tomasherceg force-pushed the feature/datapager-templating branch from d7c726c to eaf640e Compare August 31, 2025 19:12
@tomasherceg
Copy link
Member Author

I tried to track down the issue with ListItemclass vs ListItemClass, and it seems that HtmlWriter doesn't mind when it receives two attributes (class and Class) that differ only by case.

It happily renders both of them, and the browser interprets only the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants