Conversation
…concrete Conversations class Co-authored-by: rido-min <14916339+rido-min@users.noreply.github.com>
Co-authored-by: rido-min <14916339+rido-min@users.noreply.github.com>
Co-authored-by: rido-min <14916339+rido-min@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with bot framework integration
Remove concrete Conversations cast to enable DI of IConversations implementations
Dec 17, 2025
rido-min
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two locations in the codebase cast
IConversationsto the concreteConversationsclass to callGetConversationMemberAsync, preventing dependency injection of custom implementations.Changes
Added missing interface method
GetConversationMemberWithHttpMessagesAsync(string userId, string conversationId, ...)toIConversationsinterfaceGetConversationMemberAsyncextension method forIConversationsRemoved concrete casts
TeamsInfo.GetMemberAsync:((Conversations)connectorClient.Conversations).GetConversationMemberAsync(...)→connectorClient.Conversations.GetConversationMemberAsync(...)SkillHandlerImpl.OnGetMemberAsync:((Conversations)client.Conversations).GetConversationMemberAsync(...)→client.Conversations.GetConversationMemberAsync(...)Updated test mocks
MemoryConversationsBefore/After
This enables custom adapter implementations and test mocks to provide their own
IConversationsimplementations without being forced to inherit from the concreteConversationsclass.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
slack.botframework.com/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net9.0/Microsoft.Bot.Connector.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net9.0/Microsoft.Bot.Connector.Tests.deps.json /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net9.0/testhost.dll --port 46723 --endpoint 127.0.0.1:046723 --role client --parentprocessid 4929 --datacollectionport 0 --telemetryoptedin false tFrameworkAuthentication.cs(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net8.0/Microsoft.Bot.Connector.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net8.0/Microsoft.Bot.Connector.Tests.deps.json /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net8.0/testhost.dll --port 34097 --endpoint 127.0.0.1:034097 --role client --parentprocessid 4936 --datacollectionport 0 --telemetryoptedin false tFrameworkAuthentication.cs(dns block)/usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net9.0/Microsoft.Bot.Connector.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net9.0/Microsoft.Bot.Connector.Tests.deps.json /home/REDACTED/work/botbuilder-dotnet/botbuilder-dotnet/tests/Microsoft.Bot.Connector.Tests/bin/Debug/net9.0/testhost.dll --port 42185 --endpoint 127.0.0.1:042185 --role client --parentprocessid 5175 --datacollectionport 0 --telemetryoptedin false(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.