Add 'headers' option to log request headers #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridiculous
reviewed
Apr 20, 2017
README.md
Outdated
| @@ -53,13 +53,17 @@ The middleware logger can be customized with the following options: | |||
|
|
|||
| * The `:logger` option can be any object that responds to `.info(String)` | |||
| * The `:filter` option can be any object that responds to `.filter(Hash)` and returns a hash. | |||
| * The `:headers` option can be eather `:all` or array of strings. | |||
lib/grape/middleware/logger.rb
Outdated
| return request_headers if @options[:headers] == :all | ||
|
|
||
| headers_needed = Array(@options[:headers]) | ||
| Hash[request_headers.sort].select do |key, value| |
There was a problem hiding this comment.
Instead of iterating over all headers, what about just iterating over the headers_needed (which will likely be less)?
There was a problem hiding this comment.
Exactly. I will optimize this.
|
|
||
| describe '#headers if no request header' do | ||
| let(:env) { build :expected_env } | ||
| before { subject.instance_variable_set(:@env, env) } |
There was a problem hiding this comment.
Some funky formatting going on here ...
There was a problem hiding this comment.
Sorry for the carelessness... A tab character is there.
|
|
||
| context ':all option is set to option headers' do | ||
| let(:options) { { | ||
| filter: build(:param_filter), |
There was a problem hiding this comment.
These :options should only be indented 2 spaces, please
- Fix typo in README - Replace tab character with spaces and correct wrong indents. - Bugfix: headers are not sorted by keys when the option is `:all` - Optimize filtering logic
|
Thank you for the review! Now the fix is done. |
|
@yamamotok good job! |
ridiculous
approved these changes
Apr 21, 2017
|
Thank you all! |
|
Released in 1.8.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable to log request headers by
headersoption.Filtering is configurable, you can set
:allto get all headers, or set%w(cache-control version)to get only those two headers.This pull request is based on ideas in #9 and implements same functions with some improvement.