Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-up-packages #16

Merged
merged 2 commits into from
Jul 2, 2020
Merged

bump-up-packages #16

merged 2 commits into from
Jul 2, 2020

Conversation

jeong-sik
Copy link
Contributor

ESLint 가 메이저 버전업을 함에 따라 버전을 5버전으로 올렸습니다.

https://eslint.org/docs/user-guide/migrating-to-7.0.0#plugin-loading-change

노드 8은 이제 정말 안녕이네요

@jeong-sik jeong-sik requested review from J132134 and tirr-c June 25, 2020 05:20
Copy link

@tirr-c tirr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

airbnb rule을 치우고싶네요

@jeong-sik
Copy link
Contributor Author

airbnb rule을 치우고싶네요

@J132134 @tirr-c @nnyamm
여기서 논의된 적 있지만 한 번 더 확인하고 넘어가면 좋을 거 같아요.

https://rididev.slack.com/archives/GGT1R2YGM/p1580461185011600

@J132134
Copy link
Contributor

J132134 commented Jun 26, 2020

airbnb rule을 치우고싶네요

@J132134 @tirr-c @nnyamm

여기서 논의된 적 있지만 한 번 더 확인하고 넘어가면 좋을 거 같아요.

https://rididev.slack.com/archives/GGT1R2YGM/p1580461185011600

직접 eslint의 모든 rule을 커버하기는 어렵습니다.

그리고 standard 와 비교해도 airbnb가 대중적인 규칙인 것 같아요. https://www.npmtrends.com/eslint-config-airbnb-vs-eslint-config-google-vs-standard

@tirr-c
Copy link

tirr-c commented Jun 26, 2020

모든 룰을 커버해야 한다고 생각하지는 않습니다. 꼭 필요한 룰을 설정하는 것이 airbnb 룰을 끌어온 뒤에 이상한 룰에 걸릴 때마다 off를 거는 것보다 낫다고 생각합니다.

@jeong-sik
Copy link
Contributor Author

@tirr-c @J132134 @nnyamm 스크럼 때 논의를 했고 airbnb 룰을 사용하기로 결정했습니다.
그리고 서점 lint 룰은 좀 정리하기로 ... 😅

@jeong-sik jeong-sik merged commit fd798d8 into master Jul 2, 2020
@J132134 J132134 deleted the bump-eslint-version branch July 2, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants