Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding crossing minimisation and straightness model #136

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Adding crossing minimisation and straightness model #136

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
b10d8b0
Adding crossing minimisation and straightness model
stratus85 Jul 12, 2024
4abebd7
Add optional extra requirements for MIP opt
ricklupton Jul 17, 2024
46f78d5
test_hierarchy: compat with new NetworkX exception
ricklupton Jul 17, 2024
d63652a
SankeyData: store node positions and add to JSON
ricklupton Jul 17, 2024
9b57942
Installation instructions: mention floweaver[mip]
ricklupton Jul 17, 2024
6677013
Improve API, move example to docs/cookbook
ricklupton Jul 18, 2024
ed73187
docs: fix path in new layout-optimisation notebook
ricklupton Jul 18, 2024
b107536
Add tests for diagram optimisation + fixes
ricklupton Jul 18, 2024
0184994
Debugging print statements deleted
stratus85 Jul 24, 2024
393221b
Remove print statement and change minimum gap size
stratus85 Jul 26, 2024
8ed04ea
Scale added to optimise_position_model, which solved gap issue, test …
stratus85 Jul 26, 2024
fd85239
Minimum gap is scaled as well + edge_weight is squared (for now)
stratus85 Jul 26, 2024
f74be31
Correcting typo and test success
stratus85 Jul 26, 2024
4cd2844
Passing unit test test_node_positions_aligns_links_straight()
stratus85 Aug 2, 2024
5b3ff56
All new changes for the final presentation
stratus85 Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions floweaver/diagram_optimisation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ def optimise_position_model(model_inputs, scale, wslb = 1):
m += (y[v] >= y[u] + node_weight[u])

### OBJECTIVE FUNCTION: MINIMISE DEVIATION * FLOW WEIGHT
m.objective = minimize( xsum(s[edge]*edge_weight[edge] for edge in s.keys()) )
m.objective = minimize( xsum(s[edge]*edge_weight[edge]**2 for edge in s.keys()) )

# Run the model and optimise!
status = m.optimize()
Expand All @@ -545,7 +545,7 @@ def optimise_node_positions(sankey_data,
height=None,
margins=None,
scale=None,
minimum_gap=20):
minimum_gap=10):
"""Optimise node positions to maximise straightness.

Returns new version of `sankey_data` with `node_positions` set.
Expand All @@ -571,7 +571,7 @@ def optimise_node_positions(sankey_data,

model = straightness_model(sankey_data)
# FIXME this needs to know what scale we want to use?
ys = optimise_position_model(model, scale, wslb=minimum_gap)
ys = optimise_position_model(model, scale, wslb=minimum_gap*scale)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stratus85 why does the minimum gap need to be scaled? I think it probably makes sense to have this defined in terms of pixels (i.e. the actual gap in the final Sankey diagram)?

ys = {k: y + margins['top'] for k, y in ys.items()}

# Work out appropriate diagram height, if not specified explicitly
Expand Down