Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add typed parsing methods for notification payloads #22

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

happenslol
Copy link
Contributor

I think optimally I'd change the signature for ParseNotificationV2 and ParseNotificationV2WithClaim instead of creating new methods, but I'm not sure how ok you are with breaking the API. What are your thoughts?

@happenslol happenslol force-pushed the parse-notification-typed-claims branch from 07f5223 to 074745e Compare October 29, 2024 22:49
Copy link
Owner

@richzw richzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some comments

store.go Show resolved Hide resolved
@richzw
Copy link
Owner

richzw commented Oct 30, 2024

I think optimally I'd change the signature for ParseNotificationV2 and ParseNotificationV2WithClaim instead of creating new methods, but I'm not sure how ok you are with breaking the API. What are your thoughts?

I think it could better adding new methods without changing the signature of old functions for back compatible.

One more thing, Could you please add some samples of the new functions to README.md?

@happenslol

@happenslol
Copy link
Contributor Author

I think it could better adding new methods without changing the signature of old functions for back compatible.

Alright, I'll leave it as is then.

One more thing, Could you please add some samples of the new functions to README.md?

Sure, I'll add comments and documentation.

@happenslol
Copy link
Contributor Author

Should be all done, tell me if you're ok with it now!

Copy link
Owner

@richzw richzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@richzw richzw merged commit 16a3235 into richzw:master Nov 1, 2024
1 check passed
@richzw
Copy link
Owner

richzw commented Nov 1, 2024

Should be all done, tell me if you're ok with it now!

Thank you very much for your PR. The new version https://github.com/richzw/appstore/releases/tag/v1.33.0 is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants