Repository navigation
Bump golang.org/x/net to v0.57.0 (fixes reachable dnsmessage panic) - #10
Merged
richlegrand merged 1 commit intoAug 1, 2026
Merged
Conversation
govulncheck reports GO-2026-5942: parsing an invalid SVCB or HTTPS DNS resource record can panic in golang.org/x/net/dns/dnsmessage. It is reachable in this module, not just present in the graph. The mDNS resolver unpacks untrusted response records: Vulnerability richlegrand#1: GO-2026-5942 Found in: golang.org/x/net@v0.50.0 Fixed in: golang.org/x/net@v0.56.0 Example trace: internal/localdns/localdns.go:189:28: localdns.queryMDNS calls mdns.Server, which eventually calls dnsmessage.Message.Unpack A hostile or malformed .local responder on the LAN can therefore panic the CLI during mDNS resolution. This bumps x/net to v0.57.0 (current; the fix landed in v0.56.0). go get carries the rest of the golang.org/x family to a consistent set (crypto, sys, term). After the bump, govulncheck no longer reports GO-2026-5942, and `go build`, `go vet`, and `go test ./...` all pass.
Contributor
Author
|
Thanks for merging this! I have a few additional potential security-related items that I’d prefer not to discuss publicly. Would you be willing to enable GitHub’s private vulnerability reporting for this repository? Alternatively, I’m happy to use another private contact method you prefer. Once there’s a private channel, I can submit each finding separately with impact, reproduction steps, and proposed fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
govulncheckreports GO-2026-5942: parsing an invalid SVCB or HTTPS DNS resource record can panic ingolang.org/x/net/dns/dnsmessage. It is reachable from this code, not just present in the module graph, because the mDNS resolver unpacks untrusted response records:A hostile or malformed
.localresponder on the LAN can therefore panic the CLI during mDNS resolution.The change
Bump
golang.org/x/netto v0.57.0 (current; the fix landed in v0.56.0).go getcarries the rest of thegolang.org/x/*family to a consistent set (crypto,sys,term), the usual coupled release.go.mod+go.sumonly.Verification
Before and after, with
govulncheck ./...:GO-2026-5942reported, reachable vialocaldns.go:189.GO-2026-5942no longer reported.go build ./...,go vet ./..., andgo test ./...all pass.(
govulncheckalso flags GO-2026-5856 in thecrypto/tlsstandard library, fixed in Go 1.25.12 / 1.26.5. That is a toolchain update, not a dependency change, and symbol reachability does not establish that this CLI actually negotiates ECH; out of scope for this PR.)