Fix sign error in eci to ecf conversion #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting between eci and ecf, there should be a
+in the x coordinate line, not a-See here: https://github.com/shashwatak/satellite-js/blob/09b49aa6aa8962c0f954f79dd84c25ee27e453b0/src/transforms.js#L126
I've been using this js port daily for the past year now and all the observations with it have been accurate confirmed by recording broadcasts from satellites, but when I tried to use this library the angle of elevation was extremely off at every timestamp I tried. I managed to track the error down to this one sign error, and after changing it the angle of elevation in observations have worked perfectly.
I also added the GMST parameter to the
eci_to_ecffunction in the readme because it took me a little while to realize it was missing and that also affects the reported angles, so it would be nice to have that included in the readme example.