Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-code compression algorithm for Debian package #230

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

paulmillar
Copy link
Contributor

Motivation:

Newer Ubuntu releases have changed the default compression from xz to zstd. The zstd compression is not supported by dpkg in "bullseye", the current stable release of Debian.

Modification:

Hard-code the compression algorithm to use the xz algorithm.

Result:

The debbuilder.sh script now produces packages that are compatible with Debian stable/bullseye.

Closes: #222

Motivation:

Newer Ubuntu releases have changed the default compression from xz to
zstd.  The zstd compression is not supported by dpkg in "bullseye", the
current stable release of Debian.

Modification:

Hard-code the compression algorithm to use the xz algorithm.

Result:

The debbuilder.sh script now produces packages that are compatible with
Debian stable/bullseye.

Closes: richardlehane#222
@paulmillar
Copy link
Contributor Author

Please be aware that I haven't tested this change as much as I would like.

The Execute debbuilder script step in the publicDeb CI/CD job continues to work, but I haven't verified that the resulting deb file really uses xz (instead of zstd) compression.

@richardlehane
Copy link
Owner

thanks Paul, I'll check over the weekend, much appreciated :)

@paulmillar
Copy link
Contributor Author

Just (possibly) to save you some time, you can check which algorithm is used with the ar command and looking at the file extensions:

paul@celebrimbor:~/git/siegfried (fix/issue-222)$ ar -t /var/cache/apt/archives/siegfried_1.9.5-1_amd64.deb 
debian-binary
control.tar.xz
data.tar.xz
paul@celebrimbor:~/git/siegfried (fix/issue-222)$ ar -t /var/cache/apt/archives/siegfried_1.10.0-1_amd64.deb 
debian-binary
control.tar.zst
data.tar.zst
paul@celebrimbor:~/git/siegfried (fix/issue-222)$ 

This isn't 100% proof (theoretically, a file ending .xz could still be compressed using zstd), but it's probably good enough.

@richardlehane richardlehane changed the base branch from main to develop April 22, 2023 19:20
@richardlehane richardlehane merged commit c17c9a5 into richardlehane:develop Apr 22, 2023
@paulmillar paulmillar deleted the fix/issue-222 branch April 22, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken debian package for stable: "bullseye"
2 participants