-
Notifications
You must be signed in to change notification settings - Fork 0
Non breaking change #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: create-additional-screenshot-tests
Are you sure you want to change the base?
Conversation
This adds a comment onto a PR that has a failing screenshot test to aid document discoverability
This test validates the fix for issue jMonkeyEngine#2076, where missing vertex normals in software skinning caused a crash. It compares both old and new animation systems by rendering two Jaime models with modified mesh configurations.
This test verifies MotionPath functionality by animating a teapot along a predefined path. Screenshots are captured at specific frames to check the animation and visual aspects. It includes waypoint notifications and a debug shape for enhanced visualization.
This test validates the rendering of a bump-mapped quad with an orbiting point light. Screenshots are captured at frames 10 and 60 to ensure proper lighting and material behavior. The light's position is visually represented by a red sphere.
Introduce a screenshot test for OpenCL texture writing by generating and displaying a Julia set fractal. Changes include creating the `JuliaSet.cl` OpenCL kernel, a `TestWriteToTexture` Java test class, and extending the `ScreenshotTest` framework to support OpenCL-based tests.
To hopefully fix the "CL_INVALID_DEVICE_TYPE" error
Also intentionally break a test to see behaviour
🖼️ Screenshot tests have failed. The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests. 📄 Where to find the report:
✅ If you did mean to change things: ✨ If you are creating entirely new tests: Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar". See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information |
5f3f4ca
to
dff1c33
Compare
Example MR to play with the auto comment