Skip to content

Commit

Permalink
remove unnecessary error check (thirdweb-dev#120)
Browse files Browse the repository at this point in the history
  • Loading branch information
ricebin authored Mar 24, 2023
1 parent d1c742c commit 0ee6016
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions thirdweb/erc1155_signature_minting.go
Original file line number Diff line number Diff line change
Expand Up @@ -412,10 +412,7 @@ func (signature *ERC1155SignatureMinting) GenerateBatchFromTokenIds(ctx context.
Uid: id,
}

mappedPayload, err := signature.generateMessage(ctx, payload)
if err != nil {
return nil, err
}
mappedPayload := generateMessage(payload)

typedData := signerTypes.TypedData{
Types: signerTypes.Types{
Expand Down Expand Up @@ -483,7 +480,7 @@ func (signature *ERC1155SignatureMinting) GenerateBatchFromTokenIds(ctx context.
return signedPayloads, nil
}

func (signature *ERC1155SignatureMinting) generateMessage(ctx context.Context, mintRequest *Signature1155PayloadOutput) (signerTypes.TypedDataMessage, error) {
func generateMessage(mintRequest *Signature1155PayloadOutput) signerTypes.TypedDataMessage {
// If tokenID < 0, set it to MaxUin256 (to mint a new NFT)
tokenId := big.NewInt(int64(mintRequest.TokenId))
if mintRequest.TokenId < 0 {
Expand All @@ -506,7 +503,7 @@ func (signature *ERC1155SignatureMinting) generateMessage(ctx context.Context, m
"uid": mintRequest.Uid[:],
}

return message, nil
return message
}

func (signature *ERC1155SignatureMinting) mapPayloadToContractStruct(ctx context.Context, mintRequest *Signature1155PayloadOutput) (*abi.ITokenERC1155MintRequest, error) {
Expand All @@ -515,7 +512,6 @@ func (signature *ERC1155SignatureMinting) mapPayloadToContractStruct(ctx context
return nil, errors.New("Specified price was not a valid big.Int")
}


// If tokenID < 0, set it to MaxUin256 (to mint a new NFT)
tokenId := big.NewInt(int64(mintRequest.TokenId))
if mintRequest.TokenId < 0 {
Expand Down

0 comments on commit 0ee6016

Please sign in to comment.