-
Notifications
You must be signed in to change notification settings - Fork 21
Fix models integrity by using the "id" instead of "name" when dealing with models #916
Copy link
Copy link
Closed
Labels
component: labelsChanges related to labeling or categorization of issues or pull requests.Changes related to labeling or categorization of issues or pull requests.component: presetsChanges related to predefined settings or configurations.Changes related to predefined settings or configurations.component: rolesChanges related to user roles and permissions.Changes related to user roles and permissions.component: roomsChanges related to virtual meeting rooms or spaces.Changes related to virtual meeting rooms or spaces.priority: blockerIndicates that the issue or pull request is blocking progress and requires immediate attention.Indicates that the issue or pull request is blocking progress and requires immediate attention.scope: qualityChanges aimed at improving code or product quality.Changes aimed at improving code or product quality.scope: robustnessChanges aimed at enhancing the robustness of the application.Changes aimed at enhancing the robustness of the application.scope: securityChanges related to security measures and enhancements.Changes related to security measures and enhancements.type: bugIndicates that the issue or pull request addresses a bug or error.Indicates that the issue or pull request addresses a bug or error.
Milestone
Description
Metadata
Metadata
Assignees
Labels
component: labelsChanges related to labeling or categorization of issues or pull requests.Changes related to labeling or categorization of issues or pull requests.component: presetsChanges related to predefined settings or configurations.Changes related to predefined settings or configurations.component: rolesChanges related to user roles and permissions.Changes related to user roles and permissions.component: roomsChanges related to virtual meeting rooms or spaces.Changes related to virtual meeting rooms or spaces.priority: blockerIndicates that the issue or pull request is blocking progress and requires immediate attention.Indicates that the issue or pull request is blocking progress and requires immediate attention.scope: qualityChanges aimed at improving code or product quality.Changes aimed at improving code or product quality.scope: robustnessChanges aimed at enhancing the robustness of the application.Changes aimed at enhancing the robustness of the application.scope: securityChanges related to security measures and enhancements.Changes related to security measures and enhancements.type: bugIndicates that the issue or pull request addresses a bug or error.Indicates that the issue or pull request addresses a bug or error.
Describe the bug
Labels, rooms and presets are bing loaded by their names instead of their id. The should be the only and unique identifier when loading and saving those three models.
To Reproduce
Steps to reproduce the behavior: search PHP function with "byName".
Expected behavior
When dealing with records we should use the "id" column as identifier.
Possible solution
Refactor the code to use "id" and not any other column.
Additional context
It creates additional bugs related to the session.
#915 (comment)
#915 (comment)