Skip to content
This repository has been archived by the owner on Jul 8, 2021. It is now read-only.

Add getElement and getElements #16

Merged
merged 1 commit into from
Jan 7, 2019
Merged

Conversation

abenoit
Copy link

@abenoit abenoit commented Jan 7, 2019

Hello there,

Thanks for this binding library ! I've been using it to create behaviour tests in my ReasonML application.

I have been trying to snapshot test after simulating user's actions using enzyme. The snapshot method actually takes a ReasonReact.reactElement. When I tried to use getNode a warning said that the method was deprecated and that we should rather use getElement. Enzyme changelog is here https://github.com/airbnb/enzyme/blob/master/CHANGELOG.md#documentation-2

I've added the two missing methods in the bindings (I intentionally left the deprecated getNode and getNodes methods for people to get the warning message)

@rhysforyou rhysforyou merged commit 77abbb6 into rhysforyou:master Jan 7, 2019
@rhysforyou
Copy link
Owner

Thanks for this! I'll push out a new release shortly.

@rhysforyou
Copy link
Owner

Alright, I've published this as v0.6.0

@abenoit
Copy link
Author

abenoit commented Jan 7, 2019

Yay cool ! Thanks a lot 👍 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants