Skip to content

feat: add support for 'code-quality' permission - #674

Open
smlx wants to merge 1 commit into
rhysd:mainfrom
smlx:code-quality
Open

smlx wants to merge 1 commit into
rhysd:mainfrom
smlx:code-quality

Conversation

@smlx

@smlx smlx commented Jun 4, 2026

Copy link
Copy Markdown

I tried to integrate the new valid/invalid test examples with the existing test suite. Please let me know if I need to change anything there.

Closes: #672

@smlx

smlx commented Jul 10, 2026

Copy link
Copy Markdown
Author

Gentle ping @rhysd. Could I please get a review of this change? It's currently causing linting failures across any project using the code-quality permission.

@TheAlphaEngineerCode TheAlphaEngineerCode left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the permission map and the workflow- and job-level fixtures. The new scope accepts the documented read/write/none values, and the invalid-value path is covered at both levels. I ran TestLinterLintOK and TestLinterLintError on Go 1.25.12 for Windows; both pass. The unrelated full-suite environment checks require Bash/WSL and executables allowed by Windows Application Control, so I did not treat those host-specific failures as regressions in this change.

@jacobwoffenden

Copy link
Copy Markdown

@rhysd any chance this could be merged and released so super linter can be updated? thanks!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Recognize permissions.code-quality key

3 participants