Skip to content

Add systemd service for servicelog_notify #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add systemd service for servicelog_notify #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions kdump-migrate-notify.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[Unit]
Description=Register kdump migration notification
After=kdump.service
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a more robust dependency, consider using BindsTo=kdump.service instead of After=kdump.service. BindsTo implies After but also ensures that this service is stopped if kdump.service is stopped. This seems desirable since this service's purpose is tied to kdump, and it would trigger the ExecStop command to clean up the notification registration automatically when kdump is no longer active.

BindsTo=kdump.service

ConditionPathExists=/usr/lib/kdump/kdump-migrate-action.sh
ConditionPathExists=/usr/bin/servicelog_notify

[Service]
Type=oneshot
RemainAfterExit=yes
ExecStart=/usr/bin/servicelog_notify --add --command=/usr/lib/kdump/kdump-migrate-action.sh --match='refcode="#MIGRATE" and serviceable=0' --type=EVENT --method=pairs_stdin
ExecStop=/usr/bin/servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The ExecStop command might be too generic as it only specifies the --command to remove. If other notifications were registered with the same command but different match criteria, this could lead to ambiguity or incorrect removal. To ensure you are removing the exact notification added by ExecStart, it's safer to provide the same identifying parameters to the --remove command.

ExecStop=/usr/bin/servicelog_notify --remove --command=/usr/lib/kdump/kdump-migrate-action.sh --match='refcode="#MIGRATE" and serviceable=0' --type=EVENT --method=pairs_stdin


[Install]
WantedBy=multi-user.target
Loading