Skip to content

Provide documentation for reading config files#4

Open
rPraml wants to merge 1 commit intorhino:mainfrom
FOCONIS:doc-for-1722
Open

Provide documentation for reading config files#4
rPraml wants to merge 1 commit intorhino:mainfrom
FOCONIS:doc-for-1722

Conversation

@rPraml
Copy link

@rPraml rPraml commented Feb 13, 2025

Documentation for this PR mozilla/rhino#1722

@rPraml
Copy link
Author

rPraml commented Oct 7, 2025

@p-bakker ping ;)


By default, rhino reads the configuration from
- `rhino.config` file from current class' classpath
- `rhino.config` file from current threas's classpath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Threas's?

---
## Configuration

Rhino supports reading configuration from configuration files in the upcomming release (> 1.8.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rephrase to 'As of Rhino 1.8.0 ....'

- `rhino.config` file from current threas's classpath
- `rhino.config` file from current directory
- `rhino-test.config` file from current class' classpath
- `rhino-test.config` file from current threas's classpath
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

- `rhino-test.config` file from current class' classpath
- `rhino-test.config` file from current threas's classpath
- `rhino-test.config` file from current directory
- env variables (normally starting with "RHINO_")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by 'normally'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think 'typically' might be better

- `rhino.debugLinker` default value `false`
- `rhino.use_java_policy_security` default value `false`

### Notes for contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section for contributors might be more useful in the main repo under Contributing

@p-bakker
Copy link
Contributor

p-bakker commented Oct 7, 2025

@p-bakker ping ;)

Sry, completely missed this....

@rPraml
Copy link
Author

rPraml commented Oct 14, 2025

OMG 🤣
Thanks for your review. (I'm not a native speaker, but I realize I should have read it through again beforehand. 🙈)
I'll update the PR in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants