Repository navigation
Conversation
Paths passed to the file and log tools name files on the target host, which is always Linux, but they were handled with pathlib.Path, whose behaviour follows the OS the server itself runs on. A Windows-hosted server rejected "/var/log/secure" as relative and would have accepted "C:/logs/app.log" as absolute. Decide absoluteness from the string, and carry target paths as PurePosixPath so that splitting, joining and comparison stay POSIX wherever the server runs. pathlib.Path now appears only where a path names a file on the server's own filesystem: the LOCALHOST branches, which Linux-only local execution already restricts to Linux. Fixes rhel-lightspeed#633 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paths passed to the file and log tools name files on the target host, which is always Linux, but they were handled with pathlib.Path, whose behaviour follows the OS the server itself runs on. A Windows-hosted server rejected "/var/log/secure" as relative and would have accepted "C:/logs/app.log" as absolute.
Decide absoluteness from the string, and carry target paths as PurePosixPath so that splitting, joining and comparison stay POSIX wherever the server runs. pathlib.Path now appears only where a path names a file on the server's own filesystem: the LOCALHOST branches, which Linux-only local execution already restricts to Linux.
Fixes #633
Note: that this fixes up everything that I and Claude could find that was broken, but it leaves us open to reintroducing problems in the future. A more complete solution would be to have LocalPath and TargetPath aliases that we enforce everwhere (via ruff) in place of Path or PurePosixPath. I'll follow a follow-up issue for that.