Skip to content

Commit

Permalink
Merge pull request ceph#57746 from ceph/nodejs-lts-update
Browse files Browse the repository at this point in the history
mgr/dashboard: update node js version  

Reviewed-by: Nizamudeen A <nia@redhat.com>
  • Loading branch information
ivoalmeida authored Jun 7, 2024
2 parents 37816ef + 4518362 commit e082a4d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions doc/dev/developer_guide/dash-devel.rst
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@ The build process is based on `Node.js <https://nodejs.org/>`_ and requires the
Prerequisites
~~~~~~~~~~~~~

* Node 18.17.0 or higher
* NPM 9.6.7 or higher
* Node 20.13.1 or higher
* NPM 10.5.2 or higher

nodeenv:
During Ceph's build we create a virtualenv with ``node`` and ``npm``
Expand Down
2 changes: 1 addition & 1 deletion make-dist
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ build_dashboard_frontend() {

$CURR_DIR/src/tools/setup-virtualenv.sh $TEMP_DIR
$TEMP_DIR/bin/pip install nodeenv
$TEMP_DIR/bin/nodeenv --verbose -p --node=18.17.0
$TEMP_DIR/bin/nodeenv --verbose -p --node=20.13.1
cd src/pybind/mgr/dashboard/frontend

. $TEMP_DIR/bin/activate
Expand Down
2 changes: 1 addition & 1 deletion src/pybind/mgr/dashboard/frontend/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ else(WITH_SYSTEM_NPM)
OUTPUT "${mgr-dashboard-nodeenv-dir}/bin/npm"
COMMAND ${CMAKE_SOURCE_DIR}/src/tools/setup-virtualenv.sh --python=${MGR_PYTHON_EXECUTABLE} ${mgr-dashboard-nodeenv-dir}
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/pip install nodeenv
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=18.17.0
COMMAND ${mgr-dashboard-nodeenv-dir}/bin/nodeenv --verbose ${node_mirror_opt} -p --node=20.13.1
COMMAND mkdir ${mgr-dashboard-nodeenv-dir}/.npm
WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
COMMENT "dashboard nodeenv is being installed")
Expand Down

0 comments on commit e082a4d

Please sign in to comment.