efivar-types.h: fix alignment of efi_guid_t #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current alignment of 1 can lead to a lot of Walign-mismatch warnings in C++. This behavior also doesn't seem to be up to spec, as evidenced by a similar change made in the Linux ARM kernel: https://patchwork.kernel.org/project/linux-arm-kernel/patch/20190108152829.11579-1-ard.biesheuvel@linaro.org/ Signed-off-by: meator <meator.dev@gmail.com>
meator
force-pushed
the
efi_guid_t-align
branch
from
314866a to
064061f
Compare
Contributor
Author
|
I have yet to conduct testing. I have also noticed that this may (or may not) be a breaking change on some architectures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current alignment of 1 can lead to a lot of Walign-mismatch warnings in C++. This behavior also doesn't seem to be up to spec, as evidenced by a similar change made in the Linux ARM kernel:
https://patchwork.kernel.org/project/linux-arm-kernel/patch/20190108152829.11579-1-ard.biesheuvel@linaro.org/
I have not yet conducted testing, but I intend to test my project (which depends on
libefivar) as well as efibootmgr.All credit for this discovery should go to
Shellfrom#C++-generalon Libera.