IDBBatchAtomicVFS: Cannot read properties of null (reading 'fileSize')

[tetsugi]

When using the IDBBatchAtomicVFS, we encountered a crash in the jFileControl method when handling VFS.SQLITE_FCNTL_SYNC operations.
The issue occurs because file.rollback may be null when accessing file.rollback.fileSize.

wa-sqlite/src/examples/IDBBatchAtomicVFS.js

Lines 483 to 486 in 7a14d78

	case VFS.SQLITE_FCNTL_SYNC:
	this.log?.('xFileControl', file.path, 'SYNC');
	const commitMetadata = Object.assign({}, file.metadata);
	const prevFileSize = file.rollback.fileSize

I suggest adding a null check for file.rollback to prevent crashes.

wa-sqlite version: v1.06
Browser: Chrome 133.0.0, 135.0.0

[rhashimoto]

In what conditions are you seeing this happen? Are you using any PRAGMAs?

[tetsugi]

I've implemented a Kysely Dialect for wa-sqlite-async.mjs based on the official Kysely SQLite Dialect, and I'm using wa-sqlite through Kysely.

Our system implementation follows these steps:

1. User accesses the page
2. Create a Kysely instance
   • Initialize wa-sqlite with IDBBatchAtomicVFS configuration in the Driver#init method
   • All subsequent SQL is executed through the DatabaseConnection#executeQuery method
3. Perform table migrations
4. Perform CRUD operations according to user actions

This error has been reported by a small number of users via Sentry.

It seems to occur rarely at both steps 3 and 4. In both cases, the error appears to happen during the execution of sqlite3.statements(db, sql), which I implemented in DatabaseConnection#executeQuery.

Are you using any PRAGMAs?

No, I'm not using any PRAGMAs. I'm using the default configuration provided by wa-sqlite.

[tetsugi]

The issue has been resolved after integrating the fix. Thank you!