Merge pull request #107 from rhashimoto/bug-sharedservice-locking

Fix SharedService clientId locking with multiple services.
rhashimoto · Jul 31, 2023 · 122c46e · 122c46e
2 parents b58e81d + 8be5af2
commit 122c46e
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 12 deletions.
diff --git a/demo/SharedService-sw/SharedService.js b/demo/SharedService-sw/SharedService.js
@@ -144,12 +144,11 @@ export class SharedService extends EventTarget {
 
     // Acquire a Web Lock named after the clientId. This lets other contexts
     // track this context's lifetime.
-    await new Promise(resolve => {
-      navigator.locks.request(clientId, () => new Promise(releaseLock => {
-        resolve();
-        this.#onClose.signal.addEventListener('abort', releaseLock);
-      }));
-    });
+    // TODO: It would be better to lock on the clientId+serviceName (passing
+    // that lock name in the service request). That would allow independent
+    // instance lifetime tracking.
+    await SharedService.#acquireContextLock(clientId);
+
     return clientId;
   }
 
@@ -250,6 +249,17 @@ export class SharedService extends EventTarget {
       }
     });
   }
+
+  static #acquireContextLock = (function() {
+    let p;
+    return function(clientId) {
+      return p ? p : p = new Promise(resolve => {
+        navigator.locks.request(clientId, () => new Promise(_ => {
+          resolve();
+        }));
+      });
+    }
+  })();
 }
 
 /**

diff --git a/demo/SharedService/SharedService.js b/demo/SharedService/SharedService.js
@@ -131,12 +131,10 @@ export class SharedService extends EventTarget {
 
     // Acquire a Web Lock named after the clientId. This lets other contexts
     // track this context's lifetime.
-    await new Promise(resolve => {
-      navigator.locks.request(clientId, () => new Promise(releaseLock => {
-        resolve();
-        this.#onClose.signal.addEventListener('abort', releaseLock);
-      }));
-    });
+    // TODO: It would be better to lock on the clientId+serviceName (passing
+    // that lock name in the service request). That would allow independent
+    // instance lifetime tracking.
+    await SharedService.#acquireContextLock(clientId);
 
     // Configure message forwarding via the SharedWorker. This must be
     // done after acquiring the clientId lock to avoid a race condition
@@ -248,6 +246,17 @@ export class SharedService extends EventTarget {
       }
     });
   }
+
+  static #acquireContextLock = (function() {
+    let p;
+    return function(clientId) {
+      return p ? p : p = new Promise(resolve => {
+        navigator.locks.request(clientId, () => new Promise(_ => {
+          resolve();
+        }));
+      });
+    }
+  })();
 }
 
 /**