Ksampler Config Broken in new update.

[solss-bit]

I don't see a discrepancy in the lists for samplers or schedulers, but for some reason, connecting the ksampler config prevents generation until disconnected. I've only noticed this in the newest update:

• KSamplerSelect 150:148:
  • Return type mismatch between linked nodes: sampler_name, received_type(['euler', 'euler_cfg_pp', 'euler_ancestral', 'euler_ancestral_cfg_pp', 'heun', 'heunpp2', 'dpm_2', 'dpm_2_ancestral', 'lms', 'dpm_fast', 'dpm_adaptive', 'dpmpp_2s_ancestral', 'dpmpp_2s_ancestral_cfg_pp', 'dpmpp_sde', 'dpmpp_sde_gpu', 'dpmpp_2m', 'dpmpp_2m_alt', 'dpmpp_2m_cfg_pp', 'dpmpp_2m_sde', 'dpmpp_2m_sde_gpu', 'dpmpp_2m_sde_heun', 'dpmpp_2m_sde_heun_gpu', 'dpmpp_3m_sde', 'dpmpp_3m_sde_gpu', 'ddpm', 'lcm', 'ipndm', 'ipndm_v', 'deis', 'res_multistep', 'res_multistep_cfg_pp', 'res_multistep_ancestral', 'res_multistep_ancestral_cfg_pp', 'gradient_estimation', 'gradient_estimation_cfg_pp', 'er_sde', 'seeds_2', 'seeds_3', 'sa_solver', 'sa_solver_pece', 'ddim', 'uni_pc', 'uni_pc_bh2', 'legacy_rk', 'rk', 'rk_beta', 'deis_3m_ode', 'deis_2m_ode', 'deis_3m', 'deis_2m', 'res_6s_ode', 'res_5s_ode', 'res_3s_ode', 'res_2s_ode', 'res_3m_ode', 'res_2m_ode', 'res_6s', 'res_5s', 'res_3s', 'res_2s', 'res_3m', 'res_2m']) mismatch input_type(COMBO)
• BasicScheduler 150:154:
  • Return type mismatch between linked nodes: scheduler, received_type(['simple', 'sgm_uniform', 'karras', 'exponential', 'ddim_uniform', 'beta', 'normal', 'linear_quadratic', 'kl_optimal', 'bong_tangent', 'beta57']) mismatch input_type(COMBO)
    Output will be ignored

[benzimmerman]

Same happened to me when I updated today. Curiously, connecting to a Preview Any node shows the correct value, but the ComfyUI KSampler somehow thinks it's a COMBO instead of a single selected value.

[rgthree]

So all the Ksampler Config in rgthree-comfy does is set the options to the list that ComfyUI provides from the server. This should work fine with the KSampler node, which should have the same sampler/scheduler options and match. And this does work fine from what I can tell.

However, ComfyUI's COMBO lists in the front end are wildly incapable of mismatched values for combos. What is likely happening is the input you are attempting to attach to is not actually a list of samplers/schedulers from ComfyUI's backend, or, that list has been manipulated by another extension, and thusly, not compatible with the standard list.

For instance, if you are using a non-standard KSampler node that has additional options in sampler/scheduler on the node (but not adding it to ComfyUI's backend) then the COMBO from the standard list that rgthree-comfy uses is not compatible. Likewise, if you have an different custom node that hacks in new options for sampler/scheduler to the existing KSampler node, but not in a way that the list from ComfyUI's backend defines, then it would also not be compatible.

So, question: If you try after starting up with only rgthree-comfy installed and the standard KSampler, does it work? If so, then you can try to add extensions to your start up to find which one breaks these combos.

[MGiom12]

Similar phenomenon with me. Ksampler and KSampler Advance work fine when the "KSampler Config" outputs for cheduler and Sampler are connected.
But when these outputs are connected to the "Scheduler & Steps" and "Sampler" nodes that serve as input for the Custom Advanced Sampler, the error shows, with the message OP posted above.
This is since ComFy version 0.3.76, before, this worked well. (I'm on Comfy 0.3.77, rgthree nodes updated to latest nightly...).

[gabrielxcom]

Image Comparer is broken too, it won't update the newly generated images if you're running the same workflow.

[Fembro-Brite]

I updated this morning and was getting an OS error when it got to the Ksampler and was just odd. I wound up reading someone getting a similar error like a year ago actually and it turned out changing the port for the web GUI fixed it and then would break again and changing the port around was what they were doing until someone figured out that it was the user log files causing the problem after an update and said to delete the log files and it would stop. I was desperate so I just deleted them and it fixed everything I was having issues with. So I hate to throw this out there as a solution because I did it figuring its just the log files so what could it hurt and weirdly worked.

[benzimmerman]

@rgthree here is an example workflow that illustrates the problem using only Comfy Core and rgthree-comfy nodes. It fails when using either SamplerCustom or SamplerCustomAdvanced (Comfy Core) node. The same workflow using a basic KSampler appears to work. Maybe something to do with the KSamplerSelect and BasicScheduler nodes?

example.json

[alFrame]

I get the same thing on the ksampler config. I use it to setup steps, cfg, et. al, then send that throughout my workflow to various ksamplers. In one case to a "Basic Scheduler" node (Comfy Core), which converts it to sigmas, for detail daemon nodes. This broke, with a similar mismatch error message as the OP mentioned.

Now, I tried to identify the problem and then fed the "ksampler_config.py" file to an AI, explained the problem and it came up with the following, which fixed it for me.

Bare in mind, I know as much Italian (python in this case) to get myself in troubles, but not out again.

Try this at your own risk and please share if it starts tackling the problem. Because there seem multiple nodes affected.

file: https://github.com/rgthree/rgthree-comfy/blob/main/py/ksampler_config.py

`
"""Some basic config stuff I use for SDXL."""

from .constants import get_category, get_name
from nodes import MAX_RESOLUTION
import comfy.samplers

class RgthreeKSamplerConfig:
"""Some basic config stuff I started using for SDXL, but useful in other spots too."""

NAME = get_name('KSampler Config')
CATEGORY = get_category()

@classmethod
def INPUT_TYPES(cls): # pylint: disable = invalid-name, missing-function-docstring
return {
"required": {
"steps_total": ("INT", {
"default": 30,
"min": 1,
"max": MAX_RESOLUTION,
"step": 1,
}),
"refiner_step": ("INT", {
"default": 24,
"min": 1,
"max": MAX_RESOLUTION,
"step": 1,
}),
"cfg": ("FLOAT", {
"default": 8.0,
"min": 0.0,
"max": 100.0,
"step": 0.5,
}),
"sampler_name": (comfy.samplers.KSampler.SAMPLERS,),
"scheduler": (comfy.samplers.KSampler.SCHEDULERS,),
},
}

RETURN_TYPES = ("INT", "INT", "FLOAT", "STRING", "STRING") # CHANGED: Use "STRING" instead of the lists
RETURN_NAMES = ("STEPS", "REFINER_STEP", "CFG", "SAMPLER", "SCHEDULER")
FUNCTION = "main"

def main(self, steps_total, refiner_step, cfg, sampler_name, scheduler):
"""main"""
return (
steps_total,
refiner_step,
cfg,
sampler_name, # This is already a string value
scheduler, # This is already a string value
)
`

Since there is 30+ PR's, I think we're better off patching things bbs style, rather than wait for PR's to get real. No disrespect, Mr. rgthree. In the contrary, I really value your nodes! ❤️

[rossquentin]

I believe the reason there are issues is this PR that ComfyUI merged in last month (affects ComfyUI v0.3.76 and newer):
Comfy-Org/ComfyUI#10206
Comfy-Org/ComfyUI@a2d60aa

Looks like the V3 schema changes may have broken combo IO between V1 and V3 nodes (could be wrong, I'm not a python person, just did a tiny bit of reading)

[MGiom12]

@alFrame: I checked your proposal to change "ksampler_config.py", thank you for sharing! However, this did not solve it for me. With the changes as described, the 'sampler' and 'scheduler' outputs from "KSamplerAdvanced" node can no longer be connected to the corresponding inputs of the "Sampler" and "Scheduler & Steps" nodes at all...

[alFrame]

Thanks for testing this out. The reason it worked for me, is that I send the outputs from kSsampler config (rgthreee) to various kSamplers around the workflow by using a "Anything Anywhere" node from toe Use Everywhere node pack. That node sends the data as a COMBO and the kSampler Advance, the Basic Scheduler and the kSampler Select node were able to receive it. As far as I undesratnd the main issue here, it is that the rgthree ksampler config node is sending a list of sampler. The kSampler advanced is expecting a different list, and since it's not, ComfyUI crashes. Well, the node kSampler Advanced says "hold my beer".

Here's the node setup which worked for me.

I did not test dragging the noddle to the kSampler Advanced node. Sorry about that. I did now, fed the errors to the AI again and it came up whit the following ksampler_config.py

And here's the Workflow ** I tested it with.

** Use Everywhere nodes are used in this workflow.

And here's my ComfyUI setup.

Plus the problem in a nutshell (as per Deepseek):

The custom node outputs COMBO type definitions with outdated sampler/scheduler lists, causing type mismatch errors when connecting to updated ComfyUI core nodes that have expanded lists. The node needs to dynamically use ComfyUI's current lists instead of hardcoded ones.

Hope this helps, if not, sorry to have wasted your time.

[alFrame]

So, I went a step further, because my workflow broke with the above version.

Here's the node now. It outputs STRING and COMBO separate. One of either should work.

Here's the ksampler_config.py and the new workflow **

** Now uses Use Everywhere and Detail Daemon custom nodes...

Hope this helps. May it at least indicate the actual problem and paint a path to fixed it more elegantly.

[MGiom12]

Hello again @alFrame.

Thank you for all your work! Trying to correct or circumvent an error is rarely ever a waste of time! Sorry to get back to you a bit late, though...anyway:

I used the 'ksampler_config.py" you provided in a small example workflow. I use:

and I encounter the same situation on linux with torch 2.9.1 cu128 on otherwise the same setup.

In this example workflow:

rgthree-test.json

the COMBO outputs connect to the "Sampler" and "Scheduler & Steps" inputs, but error out. The STING outputs do not connect.

Using the Use Everywhere and trying to replicate your eample setup did strangely not work as well, see this example:

rgthree_test_everywhere.json

Neither of the everywhere nodes from the String nor the Combo Outputs "connect" to the inputs:

Does this example work on your end?
Thank you again for your efforts here!

[rgthree]

Thanks everyone for the filing here. I see now. So it does look like it's a bug in Comfy (or likely comfy frontend). It's probably not intentional, but the UI clearly allows the connection for a "COMBO" but then complains about it being connected. I'm not too surprised as the COMBO logic in the frontend is/was a mess.

Obviously, the regular KSampler is working correctly, but for KSamplerSelect and BasciScheduler nodes it's the front end types the ComfyUI has broken, not the actual data. You can fix it by passing it through an intermediate "" type. Some may notice the Use Everywhere may work (I've not tested this, but if it clobbers the type into an any/"" then it would work).

You can also use the Power Puter to simply pass the inputs through, but with the "*" type as the output:

I've also attached a working workflow: scheduler_puter.json

Not sure if ComfyUI will fix this or there's more rgthree-comfy could do to make it compatible beyond the regular KSampler node, but for now this will work.

[alFrame]

@MGiom12 Thanks! Appreciate you help uncover this.

The KSampler Advanced path works in your workflow "rgthree-test.json", but the one above doesn't. That's why I connected it through the UE nodes. It's the only render path in my workflow that uses the KSamplerSelect and the BasicScheduler node.

the "rgthree_test_everywhere.json" workflow works fine. Please check that you enabled the "UE Connectable Inputs" on your "Sampler" and the "Scheduler & Steps" node and it should work for you as well.

Then both UE nodes connect. Here's the COMBO

And here's the STRING (Ironically the option "String to Combo" set to "yes"...)

HOWEVER !! Only the connection through the STRING output works, which is, you guessed it, converted to COMBO...

All those receiving nodes are form the house of ComfyUI, it's on their turf to fix this.

[alFrame]

@rgthree thank you! And thanks for that workflow example.

Let's hope this get's fixed by either ComfyUI, or the frontend. This seems a logical one to work out.

I am not a fan of the direction that ComfyUI takes lately. RE: subgraphs, now nodes 2.0?!? What worries me though, is 17 million of investment and statements like "it works on my machine and I don't use custom nodes, so, hold my beer", while custom nodes are a top priority on the list of the future development of ComfyUI...

And quite frankly, if your custom nodes stop working, I am screwed...

P.S. Never mind this insane workflow. To my defense, it works surprisingly well with that many nodes. And most of them 722 nodes of your pack, are Group Bypasser and Label nodes. Still, I'd have to replace them all if your pack retires.