import/export CSV and JSON files compatible with Lego Pick a Brick#1041
Open
mgodineau wants to merge 3 commits intorgriebl:mainfrom
Open
import/export CSV and JSON files compatible with Lego Pick a Brick#1041mgodineau wants to merge 3 commits intorgriebl:mainfrom
mgodineau wants to merge 3 commits intorgriebl:mainfrom
Conversation
Contributor
|
How it handles items that have multiple PCCs for a color of an item? Do you add each as a new line in the exported document? Lego PaB not always uses the highest one. |
Author
|
When exporting, I just pick the first pcc in the list that matches the desired color. I admit I haven't given much more though to it. I just naively assumed that PaB would recognise every pcc, as long as the part is available. |
Author
|
I addressed the pcc issue. Now I make requests to the lego pab website to check which pcc are available, all during csv and json export. Even tho it works, the whole process is now pretty slow, and there is still room for optimisation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds import and export options to work with CSV and Json files. These files are compatible with the online Lego Pick a brick service. This allows to order a whole set of parts there easily.