-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLD: Added interpolate to meson #34
Conversation
cc @rgommers |
It seems like work is yet to be done to create this extension. I checked, cython_blas = py3.extension_module('cython_blas',
_generate_cy[0], # cython_blas.pyx
# TODO: this mixed source case isn't working yet given Meson Cython support
# [_generate_cy[0], # cython_blas.pyx
# _generate_cy[2], # cython_blas.pxd
# _generate_cy[4], # _blas_subroutines.h
# 'fortran_defs.h',
# ],
link_with : fwrappers,
include_directories : inc_np,
dependencies : [py3_dep, blas],
install : true,
subdir : 'scipy/linalg')
py3.extension_module('cython_lapack',
_generate_cy[1], # cython_lapack.pyx
# TODO: this mixed source case isn't working yet given Meson Cython support
# [_generate_cy[1], # cython_lapack.pyx
# _generate_cy[3], # cython_lapack.pxd
# _generate_cy[5], # _lapack_subroutines.h
# 'fortran_defs.h',
# ],
link_with : fwrappers,
include_directories : inc_np,
dependencies : [py3_dep, blas],
install : true,
subdir : 'scipy/linalg') |
It is created, but adding a dependency on it is difficult. I filed an upstream issue for it, tracked in #31. I suggest to add a comment to |
The tests are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just pushed a small fix for Fortran build flags. Thanks @czgdp1807!
Reference issue
What does this implement/fix?
Additional information