Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: Added interpolate to meson #34

Merged
merged 11 commits into from
Jul 7, 2021
Merged

Conversation

czgdp1807
Copy link

Reference issue

What does this implement/fix?

Additional information

@czgdp1807
Copy link
Author

cc @rgommers

@czgdp1807
Copy link
Author

/home/runner/work/scipy/scipy/scipy/interpolate/_ppoly.pyx:14:0: 'scipy/linalg/cython_lapack.pxd' not found

It seems like work is yet to be done to create this extension. I checked, linalg/meson.build. Found the following,

cython_blas = py3.extension_module('cython_blas',
  _generate_cy[0],  # cython_blas.pyx
  # TODO: this mixed source case isn't working yet given Meson Cython support
#  [_generate_cy[0],  # cython_blas.pyx
#   _generate_cy[2],  # cython_blas.pxd
#   _generate_cy[4],  # _blas_subroutines.h
#   'fortran_defs.h',
#  ],
  link_with : fwrappers,
  include_directories : inc_np,
  dependencies : [py3_dep, blas],
  install : true,
  subdir : 'scipy/linalg')

py3.extension_module('cython_lapack',
  _generate_cy[1],  # cython_lapack.pyx
  # TODO: this mixed source case isn't working yet given Meson Cython support
#  [_generate_cy[1],  # cython_lapack.pyx
#   _generate_cy[3],  # cython_lapack.pxd
#   _generate_cy[5],  # _lapack_subroutines.h
#   'fortran_defs.h',
#  ],
  link_with : fwrappers,
  include_directories : inc_np,
  dependencies : [py3_dep, blas],
  install : true,
  subdir : 'scipy/linalg')

@czgdp1807 czgdp1807 changed the title [WIP] BLD: Added interpolate to meson BLD: Added interpolate to meson Jul 7, 2021
@rgommers
Copy link
Owner

rgommers commented Jul 7, 2021

It seems like work is yet to be done to create this extension. I checked, linalg/meson.build. Found the following,

It is created, but adding a dependency on it is difficult. I filed an upstream issue for it, tracked in #31.

I suggest to add a comment to _ppoly that it depends on cython_lapack.pxd and comment out the code to build it. I think it's the very last thing to do to make everything that has the Cython linalg dependency to work; and perhaps a good hack is needed until the issue is addressed in Meson.

@czgdp1807
Copy link
Author

The tests are passing.

Copy link
Owner

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just pushed a small fix for Fortran build flags. Thanks @czgdp1807!

@rgommers rgommers merged commit de5947a into rgommers:meson Jul 7, 2021
@czgdp1807 czgdp1807 deleted the interp branch July 7, 2021 10:29
rgommers pushed a commit that referenced this pull request Jul 10, 2021
rgommers pushed a commit that referenced this pull request Jul 15, 2021
rgommers pushed a commit that referenced this pull request Jul 27, 2021
Smit-create pushed a commit to Smit-create/scipy that referenced this pull request Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants