Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use run_command for building cython --cplus code #25

Closed
rgommers opened this issue Jun 26, 2021 · 3 comments
Closed

Don't use run_command for building cython --cplus code #25

rgommers opened this issue Jun 26, 2021 · 3 comments

Comments

@rgommers
Copy link
Owner

This is now done in scipy.stats, see #23 (comment). It should be using custom_target, not run_command.
@rgommers rgommers mentioned this issue Jun 26, 2021
Closed
41 tasks
@czgdp1807
Copy link

Thanks for opening the issue. I will open a PR on Monday to fix this.

rgommers added a commit that referenced this issue Jun 27, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
263b69d 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
@rgommers rgommers mentioned this issue Jun 27, 2021
Merged
@rgommers
Copy link
Owner Author

It was bothering me, since on each ninja invocation it was rebuilding all those files. So I had a look, and it's mostly fixed in gh-27.

rgommers added a commit that referenced this issue Jun 27, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
ba8e6df 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
rgommers added a commit that referenced this issue Jun 27, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
984fee4 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
@rgommers
Copy link
Owner Author

fixed in gh-27

rgommers added a commit that referenced this issue Jun 27, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
0bcf4e1 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
rgommers added a commit that referenced this issue Jun 29, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
35c8859 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
rgommers added a commit that referenced this issue Jul 3, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
75de070 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
rgommers added a commit that referenced this issue Jul 10, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
82dbf2e 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
rgommers added a commit that referenced this issue Jul 15, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
170be29 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
@noDGodiaev noDGodiaev mentioned this issue Jul 22, 2021
Closed
rgommers added a commit that referenced this issue Jul 27, 2021
@rgommers
BLD: fix boost Cython compilation with Meson
a05fd96 
This gets rid of `run_command`, and replaces it with use of
`custom_target`. This means things now run at build-time rather
than at configure-time, and cache will work correctly.

Closes #25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rgommers @czgdp1807