This repository was archived by the owner on Mar 6, 2019. It is now read-only.
WIP: Clean bash scripts #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename file to fix typo Activate unofficial bash strict mode Add logging facility Exit with error if user is not root Stop upgrading the target machine
Activate unofficial bash strict mode Add logging facility Use subshell instead of cd into a folder and go back Add quotes to avoid array variables being incorrectly expanded on space Access arrays using values instead of index
Activate unofficial bash strict mode Add logging facility Add log messages Don't fail if node_modules directory already exists Don't fail if symbolic links exist; warn instead Use subshell instead of cd into a folder and back Use basename to get folder name from path instead of relying on another array
We previously had to maintain two separate arrays, one with path and one with just the folder name. Both had to have the exact same order. We now use `basename` in scripts which require it, removing the need of this 'duplicate' array.
Activate unofficial bash strict mode Add logging facility Add log messages Add counter to know how many projects there are Use locally installed bower instead of global one, if it is available Exit if bower isn't found Use subshells instead of cd into a folder and back Use values instead of index to access arrays
Activate unofficial bash strict mode Add logging facility Add log messages Use subshells instead of cd into a folder and back Better check for existence of `compile.sh`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.