Skip to content

Commit

Permalink
Fix url modification on link click
Browse files Browse the repository at this point in the history
We should not modify the URL when clicking on links, because this will
reset the currently applied filter.

Signed-off-by: Sascha Grunert <sgrunert@suse.com>
  • Loading branch information
saschagrunert committed Aug 15, 2019
1 parent ec04e18 commit a0e9de1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/app/main/main.component.html
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
</ul>
<ul class="navbar-nav">
<li class="nav-item">
<a (click)="openModal()" href="#" id="aboutLink" class="nav-link">About</a>
<a (click)="openModal()" id="aboutLink" class="nav-link">About</a>
</li>
<li class="nav-item" id="settingsButton"><app-settings></app-settings></li>
</ul>
Expand Down
2 changes: 1 addition & 1 deletion src/app/settings/settings.component.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<a href="#" id="settingsLink" (click)="openModal(content)" class="nav-link">
<a id="settingsLink" (click)="openModal(content)" class="nav-link">
<fa-icon class="icon" [icon]="faCogs" size="lg"></fa-icon>
</a>
<ng-template #content let-modal>
Expand Down
4 changes: 4 additions & 0 deletions src/styles.css
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ html {
}
}

.nav-link {
cursor: pointer;
}

.sidebar .nav-link {
font-weight: 500;
color: #333;
Expand Down

0 comments on commit a0e9de1

Please sign in to comment.