Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4: add support for no_std behind feature #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michalfita
Copy link

This PR fixes broken support for no_std by following the well recognized pattern of default std feature, which when not present turns the #![no_std] flag in lib.rs on. This method do not break unit tests or benchmarks.

Hopefully it can get merged and let nuta/kerla#70 implement ext2 filesystem using this crate.

In fact the pattern is the orther way round, where there is `std` feature on the default list and can be disabled.
@michalfita michalfita mentioned this pull request Nov 19, 2021
2 tasks
@jackpot51
Copy link

@rexlunae could you take a look at this and merge?

@aruiz
Copy link

aruiz commented May 19, 2022

stumbled upon this, I'd appreciate a fix+release

@halotroop2288
Copy link

I've merged it into https://github.com/ainex-project/simple-endian-rs so we can use the master branch as an "up-to-date" version if the maintainer of this never comes back (they haven't had activity on GitHub in quite some time). I'll go ahead and merge any other important bug fixes there, cause it's important to have working dependencies.

@aruiz
Copy link

aruiz commented Feb 21, 2023

I much rather point people to crates.io than a github endpoint.

@jackpot51 forked under the Redox namespace, Jeremy and I have discussed a few times in the past about properly forking this and create a new crate that is properly maintained, I think we should just do it, we can co-maintain it and make releases from time to time

@halotroop2288
Copy link

Jeremy and I have discussed a few times in the past about properly forking this and create a new crate that is properly maintained

Good luck! I'd love to see it.

@michalfita
Copy link
Author

What about creating an GitHub organisation and do it there? We could take a few interested parties as owners and release as maybe simply-endian.

@aruiz
Copy link

aruiz commented Feb 21, 2023

That is a great idea, the osdev-rust organization could be a great host actually, I already maintain a repo there.

osdev-simple-endian seems like a sensible namespaced fork :)

What do you think?

@michalfita
Copy link
Author

Everything that works. Let's make sure the crates have a bus set up (does that initiative still works?).

@mkroening
Copy link

FYI: I have just published rust-osdev/endian-num with a focus on following core::num conventions. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants