-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #4: add support for no_std
behind feature
#5
base: master
Are you sure you want to change the base?
Fixes #4: add support for no_std
behind feature
#5
Conversation
In fact the pattern is the orther way round, where there is `std` feature on the default list and can be disabled.
@rexlunae could you take a look at this and merge? |
stumbled upon this, I'd appreciate a fix+release |
I've merged it into https://github.com/ainex-project/simple-endian-rs so we can use the master branch as an "up-to-date" version if the maintainer of this never comes back (they haven't had activity on GitHub in quite some time). I'll go ahead and merge any other important bug fixes there, cause it's important to have working dependencies. |
I much rather point people to crates.io than a github endpoint. @jackpot51 forked under the Redox namespace, Jeremy and I have discussed a few times in the past about properly forking this and create a new crate that is properly maintained, I think we should just do it, we can co-maintain it and make releases from time to time |
Good luck! I'd love to see it. |
What about creating an GitHub organisation and do it there? We could take a few interested parties as owners and release as maybe |
That is a great idea, the osdev-rust organization could be a great host actually, I already maintain a repo there. osdev-simple-endian seems like a sensible namespaced fork :) What do you think? |
Everything that works. Let's make sure the crates have a bus set up (does that initiative still works?). |
FYI: I have just published rust-osdev/endian-num with a focus on following |
This PR fixes broken support for
no_std
by following the well recognized pattern of defaultstd
feature, which when not present turns the#![no_std]
flag inlib.rs
on. This method do not break unit tests or benchmarks.Hopefully it can get merged and let nuta/kerla#70 implement ext2 filesystem using this crate.