Make crate no_std compatible. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demindiro
commented
Jun 14, 2021
src/specific_endian.rs
Outdated
Comment on lines
455
to
514
| let value = match foo.to_native() { | ||
| EndianAwareExample::BigEndianFunction(v) => v, | ||
| // TODO this doesn't seem right? It'll cause the assert to always fail. | ||
| EndianAwareExample::LittleEndianFunction(_v) => 0, | ||
| }; | ||
| assert_eq!(value, 0x0f000000000000000); |
There was a problem hiding this comment.
This doesn't seem right to me? If to_native would return LittleEndianFunction on a different platform the test would fail because 0 != 0x0f000000000000000
It only required replacing `std` with `core` and removing all `println`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It only required replacing
stdwithcoreand removing allprintlns. Theprintlns in the benchmarks have been replaced withblack_box(which it should have been in the first place because otherwise you're measuring I/O overhead)