Skip to content

fix: settling delay default + feat: cleanup command#24

Merged
dnorth98 merged 4 commits intomainfrom
feature/dnorth/fix-settling-delay-default
Feb 10, 2026
Merged

fix: settling delay default + feat: cleanup command#24
dnorth98 merged 4 commits intomainfrom
feature/dnorth/fix-settling-delay-default

Conversation

@dnorth98
Copy link
Contributor

@dnorth98 dnorth98 commented Feb 10, 2026

Summary

  • Settling delay fix: The squash merge of PR perf: replace hard-coded sleeps, configurable settling delay, larger batches #23 left inconsistent settling_delay defaults — aligns all to 0.0
  • Cleanup command: Adds --cleanup mode to discover and delete all test spaces matching a prefix, replacing manual curl calls
    • --dry-run support to preview what would be deleted
    • --yes flag to skip confirmation prompt (useful for CI/scripts)
    • Discovers spaces via v2 API with pagination, deletes via v1 API
    • 17 new tests covering discovery, deletion, dry-run, and confirmation flows

Test plan

  • ruff check . — passes
  • ruff format --check . — passes
  • pytest -n auto — 605 tests pass
  • Integration tested: created data with --count 1, verified --cleanup --dry-run found it, then --cleanup --yes deleted it, then re-ran cleanup to confirm no spaces remain

🤖 Generated with Claude Code

The squash merge of PR #23 left the orchestrator __init__ default at
1.0 and both docs showing 1.0, while the generators and argparse
already had 0.0. This aligns everything.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings February 10, 2026 21:11
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the settling_delay default across the orchestrator and documentation to 0.0 so runtime behavior and docs match the intended “no delay unless needed” approach for eventual consistency.

Changes:

  • Update ConfluenceDataGenerator.__init__ default settling_delay from 1.0 to 0.0.
  • Update --settling-delay defaults and wording in README.md and CLAUDE.md to reflect 0.0.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
confluence_data_generator.py Sets orchestrator’s settling_delay default to 0.0 to match CLI and generator defaults.
README.md Updates CLI options table default and clarifies rationale for 0.0.
CLAUDE.md Updates command line options table default for --settling-delay to 0.0.

Adds a `--cleanup` mode that discovers all spaces matching the prefix
and deletes them via the REST API, replacing manual curl calls. Supports
`--dry-run` to preview and `--yes` to skip confirmation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dnorth98 dnorth98 changed the title fix: correct settling delay default to 0.0 fix: settling delay default + feat: cleanup command Feb 10, 2026
@dnorth98 dnorth98 requested a review from Copilot February 10, 2026 21:36
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

…URL encoding

- Reject empty/whitespace prefix to prevent matching all spaces
- Use `with requests.Session()` context manager to prevent session leaks
- Add timeout=30 and RequestException handling on all HTTP calls
- URL-encode space keys in delete URL
- Add 4 new tests for empty prefix, whitespace prefix, and network errors

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@dnorth98 dnorth98 merged commit 7a15abb into main Feb 10, 2026
5 checks passed
@dnorth98 dnorth98 deleted the feature/dnorth/fix-settling-delay-default branch February 10, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant