fix: settling delay default + feat: cleanup command#24
Merged
Conversation
The squash merge of PR #23 left the orchestrator __init__ default at 1.0 and both docs showing 1.0, while the generators and argparse already had 0.0. This aligns everything. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Aligns the settling_delay default across the orchestrator and documentation to 0.0 so runtime behavior and docs match the intended “no delay unless needed” approach for eventual consistency.
Changes:
- Update
ConfluenceDataGenerator.__init__defaultsettling_delayfrom1.0to0.0. - Update
--settling-delaydefaults and wording inREADME.mdandCLAUDE.mdto reflect0.0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
confluence_data_generator.py |
Sets orchestrator’s settling_delay default to 0.0 to match CLI and generator defaults. |
README.md |
Updates CLI options table default and clarifies rationale for 0.0. |
CLAUDE.md |
Updates command line options table default for --settling-delay to 0.0. |
Adds a `--cleanup` mode that discovers all spaces matching the prefix and deletes them via the REST API, replacing manual curl calls. Supports `--dry-run` to preview and `--yes` to skip confirmation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…URL encoding - Reject empty/whitespace prefix to prevent matching all spaces - Use `with requests.Session()` context manager to prevent session leaks - Add timeout=30 and RequestException handling on all HTTP calls - URL-encode space keys in delete URL - Add 4 new tests for empty prefix, whitespace prefix, and network errors Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settling_delaydefaults — aligns all to0.0--cleanupmode to discover and delete all test spaces matching a prefix, replacing manualcurlcalls--dry-runsupport to preview what would be deleted--yesflag to skip confirmation prompt (useful for CI/scripts)Test plan
ruff check .— passesruff format --check .— passespytest -n auto— 605 tests pass--count 1, verified--cleanup --dry-runfound it, then--cleanup --yesdeleted it, then re-ran cleanup to confirm no spaces remain🤖 Generated with Claude Code