Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #311 #314

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Fix Issue #311 #314

merged 1 commit into from
Dec 9, 2021

Conversation

erdos4d
Copy link
Contributor

@erdos4d erdos4d commented Dec 7, 2021

I'm running Django 4.0rc1 and have the same problem as described in issue #311. This fixes it for me.

I'm running Django 4.0rc1 and have the same problem as described in issue revsys#311. This fixes it for me.
@syphar
Copy link
Contributor

syphar commented Dec 9, 2021

@KristianOellegaard this is blocking us upgrading to Django 4.0.

Where can we help to get this merged and released? Testing this?

also, perhaps @codingjoe can help?

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2021

Codecov Report

Merging #314 (ab738ba) into master (f5978d4) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #314      +/-   ##
==========================================
+ Coverage   75.32%   75.37%   +0.04%     
==========================================
  Files          40       40              
  Lines         531      532       +1     
  Branches       70      106      +36     
==========================================
+ Hits          400      401       +1     
  Misses        115      115              
  Partials       16       16              
Impacted Files Coverage Δ
health_check/views.py 96.07% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5978d4...ab738ba. Read the comment docs.

@KristianOellegaard KristianOellegaard merged commit 9e9d5ec into revsys:master Dec 9, 2021
@syphar
Copy link
Contributor

syphar commented Dec 9, 2021

wow, that was quick! ❤️

@codingjoe
Copy link
Collaborator

Released in 3.16.5 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants