Skip to content

Conversation

yeonkim1213
Copy link
Contributor

@yeonkim1213 yeonkim1213 commented Sep 24, 2025

Does this PR close any open issues?

Closes #784

Give a longer description of what this PR addresses and why it's needed

Fix libraries in random blocks fail to produce sequences

Provide pictures/videos of the behavior before and after these changes (optional)

Before
image

After

"sequence": {
    "order": "fixed",
    "components": [
      "introduction",
      "$mic-check.co.audioTest",
      {
        "id": "test",
        "order": "random",
        "components": [
          {
            "id": "critiquePart",
            "components": [
              "critiqueCalvi1",
              "critiqueCalvi2",
              "critiqueUntimelyDeath",
              "critiqueWealth"
            ],
            "order": "random"
          },
          "drawingTraining",
          {
            "id": "drawingPart",
            "components": [
              "drawingTree",
              "drawingNetwork",
              "drawingBpm",
              "drawingRanking",
              "drawing100m"
            ],
            "order": "random"
          },
          "$mini-vlat.se.full"
        ]
      }
    ]
  }

when config.json looks like the one above, the random sequence is generated correctly, and the mini-VLAT is also generated in a latin square sequence.

minivlatTest.mp4

Are there any additional TODOs before this PR is ready to go?

No

Copy link

github-actions bot commented Sep 24, 2025

A preview of 8b32a1c is uploaded and can be seen here:

https://revisit.dev/study/PR828

Changes may take a few minutes to propagate.

@yeonkim1213 yeonkim1213 linked an issue Sep 24, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Libraries in random blocks fail to produce sequences
1 participant