Ranking widget #817
Open
Ranking widget #817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A preview of 5cb988d is uploaded and can be seen here: ✨ https://revisit.dev/study/PR817 ✨ Changes may take a few minutes to propagate. |
Open
JackWilb
requested changes
Oct 1, 2025
src/parser/types.ts
Outdated
Comment on lines
572
to
581
| ```js | ||
| { | ||
| "id": "ranking-sublist", | ||
| "type": "ranking-sublist", | ||
| "prompt": "Rank the following options", | ||
| "location": "belowStimulus", | ||
| "options": ["Option 1", "Option 2", "Option 3"] | ||
| "numItems": 2 | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Add some more docs, an example of each type
There was a problem hiding this comment.
Added docs and examples
Comment on lines
143
to
165
| if ((matrixAnswers && matrixResponse.length > 0) || (rankingAnswers && rankingResponse.length > 0)) { | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
| const updatedValues: Record<string, any> = { ...answerValidator.values }; | ||
| // Adjust object to have new matrix response values | ||
| matrixResponse.forEach((r) => { | ||
| const { id } = r; | ||
| updatedValues[id] = { | ||
| ...answerValidator.getInputProps(id).value, | ||
| ...matrixAnswers[id], | ||
| }; | ||
| }); | ||
|
|
||
| rankingResponse.forEach((r) => { | ||
| const { id } = r; | ||
| updatedValues[id] = { | ||
| ...answerValidator.getInputProps(id).value, | ||
| ...rankingAnswers[id], | ||
| }; | ||
| }); | ||
|
|
||
| // update answerValidator | ||
| answerValidator.setValues(updatedValues); | ||
| } |
There was a problem hiding this comment.
Do we need 2 ifs? 1 if is okay? no if?
There was a problem hiding this comment.
Removed if statement
There was a problem hiding this comment.
Duplicate some of this into demo-survey
There was a problem hiding this comment.
Duplicated to demo-survey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #690
Give a longer description of what this PR addresses and why it's needed
Provide pictures/videos of the behavior before and after these changes (optional)
Sub-list ranking mode
ranking-sublist.mov
Categorical binning mode
categorical.mov
Pairwise comparison mode
ranking-pairwise.mov
Are there any additional TODOs before this PR is ready to go?
TODOs:
Reference
https://ui.mantine.dev/category/dnd/
https://dev.to/kelseyroche/a-beginners-guide-to-drag-and-drop-with-dnd-kit-in-react-5hfe