feat(reason-skia): bind to FontManager matchFamilyCharacterStyle #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryphe
reviewed
Jul 6, 2020
…t/reason-skia/match-family-character-style
bryphe
reviewed
Jul 6, 2020
Comment on lines
+101
to
+108
| let maybeTypeface = | ||
| FontManager.matchFamilyStyleCharacter( | ||
| fontManager, | ||
| "Arial", | ||
| style, | ||
| ["en_US"], | ||
| char, | ||
| ); |
There was a problem hiding this comment.
Awesome!
Does this work on all platforms? If so - we might want to add a test case for this, too!
There was a problem hiding this comment.
I'm actually not sure! We'll see when CI is finished, I guess!
There was a problem hiding this comment.
Actually it looks like it does! The hard part about adding tests for it is Linux -- CI gives DejaVu Sans, but Im not sure what other distros will return. What do you think is the best course of action?
bryphe
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does some non-traditional Caml operations like shifting/or-ing bits. I think I got it all right, but if not, please let me know! I'll add some examples to SkiaFontManagerCli for it.