Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): Fix wrong font families in code blocks #906

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

zbaylin
Copy link
Member

@zbaylin zbaylin commented Jun 9, 2020

When I was originally testing this it was picking up my system monospaced fonts so I didnt notice the font props were incorrect. However any path based font is going to be incorrect.

My bad 🤦‍♂️.

@zbaylin zbaylin requested a review from bryphe June 9, 2020 01:43
Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@github-actions
Copy link

github-actions bot commented Jun 9, 2020

I have updated your lock dirs and formatted the code.
Please @zbaylin pull the last commit before pushing any more changes.

@zbaylin zbaylin merged commit b77b829 into master Jun 9, 2020
@Et7f3 Et7f3 deleted the fix/markdown/code-fonts branch June 16, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants