Enable bytecode builds #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this function was called "revery_alertOpenFiles_bytcode" which would result in a build failure using the bytecode backend
Et7f3
approved these changes
Dec 29, 2019
|
merge #691 two times 😂 |
|
Ahh yeah this is going into the feat/hot-reload branch so that's why we need it twice |
Et7f3
pushed a commit
that referenced
this pull request
Jun 7, 2020
* Native/dialog.c: Rename "revery_alertOpenFiles_bytecode" (#691) Previously this function was called "revery_alertOpenFiles_bytcode" which would result in a build failure using the bytecode backend * Add esy run-native and esy run-bytecode scripts
Et7f3
pushed a commit
to Et7f3/revery
that referenced
this pull request
Jun 7, 2020
* Native/dialog.c: Rename "revery_alertOpenFiles_bytecode" (revery-ui#691) Previously this function was called "revery_alertOpenFiles_bytcode" which would result in a build failure using the bytecode backend * Add esy run-native and esy run-bytecode scripts
Et7f3
pushed a commit
to Et7f3/revery
that referenced
this pull request
Jun 9, 2020
* Native/dialog.c: Rename "revery_alertOpenFiles_bytecode" (revery-ui#691) Previously this function was called "revery_alertOpenFiles_bytcode" which would result in a build failure using the bytecode backend * Add esy run-native and esy run-bytecode scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a really simple fix to get bytecode builds working (updates
examples/duneto provide the proper ocamlc flags & allow building bytecode) and then 2 simpleesyscripts to get build bytecode/native executables work.