Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SVG): don't use unique_ptr #32

Merged
merged 5 commits into from
Apr 29, 2021
Merged

fix(SVG): don't use unique_ptr #32

merged 5 commits into from
Apr 29, 2021

Conversation

zbaylin
Copy link
Member

@zbaylin zbaylin commented Apr 29, 2021

This was causing segfaults.

@zbaylin zbaylin requested a review from bryphe April 29, 2021 01:10
Copy link
Member

@bryphe bryphe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @zbaylin !

Do you think we can add in the ref/unref functionality here, too?

void sk_svgdom_ref(const sk_svgdom_t* svg) {
    SkSafeRef(AsSVGDOM(svg));
}

void sk_svgdom_unref(const sk_svgdom_t *svg) {
    SkSafeUnref(AsSVGDOM(svg));
}

@zbaylin zbaylin merged commit 526fdf5 into master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants