Skip to content

Commit

Permalink
Update install command for feather-format, update test to check for i…
Browse files Browse the repository at this point in the history
…nstalled library if needed
  • Loading branch information
kkraus14 committed Feb 12, 2019
1 parent 7011a97 commit 5e7c175
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ci/gpu/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ pip install cupy-cuda92

# Temporarily install feather for testing
logger "conda install feather-format"
conda install -y feather-format
conda install -c conda-forge -y feather-format

logger "Python py.test for libcudf..."
cd $WORKSPACE/cpp/build/python
Expand Down
10 changes: 10 additions & 0 deletions python/cudf/tests/test_feather.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,16 @@ def gdf(pdf):

@pytest.fixture
def feather_file(tmp_path_factory, pdf):
from distutils.version import LooseVersion
if LooseVersion(pd.__version__) < LooseVersion('0.24'):
try:
import feather # noqa F401
_have_feather = True
except ImportError:
_have_feather = False
if not _have_feather:
pytest.skip('Feather is not installed and is required for Pandas <'
' 0.24')
fname = tmp_path_factory.mktemp("feather") / "test.feather"
pdf.to_feather(fname)
return fname
Expand Down

0 comments on commit 5e7c175

Please sign in to comment.