fix: QA-02.01 to return NeedsReview #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change closes issue #145 by updating the evaluation logic to recognize that not all repositories will have enabled the GitHub dependency graph and the setting is not enabled by default. Therefore, the absence of this data in a repository is not a clearcut failure, but rather a mixed signal. As such, the evaluation now returns NeedsReview rather than Failed in cases where the API indicates no dependency management. This change was tested with the result: ```yaml - requirement-id: OSPS-QA-02.01 applicability: - Maturity Level 1 - Maturity Level 2 - Maturity Level 3 description: When the package management system supports it, the source code repository MUST contain a dependency list that accounts for the direct language dependencies. result: Needs Review message: No dependency manifests found in the GitHub dependency graph API. Review project to ensure dependencies are managed. steps: - github.com/revanite-io/pvtr-github-repo/evaluation_plans/osps/quality.verifyDependencyManagement steps-executed: 1 start: "2025-09-21T14:09:04-04:00" end: "2025-09-21T14:09:04-04:00" ``` Signed-off-by: Travis Truman <trumant@gmail.com>
Kusari Analysis Results:
No pinned version dependency changes, code issues or exposed secrets detected! Note View full detailed analysis result for more information on the output and the checks that were run.
Found this helpful? Give it a 👍 or 👎 reaction! |
jmeridth
approved these changes
Sep 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change closes issue #145 by updating the evaluation logic to recognize that not all repositories will have enabled the GitHub dependency graph and the setting is not enabled by default.
Therefore, the absence of this data in a repository is not a clearcut failure, but rather a mixed signal. As such, the evaluation now returns NeedsReview rather than Failed in cases where the API indicates no dependency management.
This change was tested with the result: