Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close the notify channel in throttler #41

Merged
merged 1 commit into from
Dec 25, 2021
Merged

Close the notify channel in throttler #41

merged 1 commit into from
Dec 25, 2021

Conversation

zhaijian
Copy link
Contributor

@zhaijian zhaijian commented Dec 24, 2021

channel close, notify should close

channel close, notify should close
@codecov-commenter
Copy link

Codecov Report

Merging #41 (0f4e7af) into master (e98f8bb) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   87.13%   87.16%   +0.03%     
==========================================
  Files          10       10              
  Lines         412      413       +1     
==========================================
+ Hits          359      360       +1     
  Misses         49       49              
  Partials        4        4              
Impacted Files Coverage Δ
flow/throttler.go 69.84% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98f8bb...0f4e7af. Read the comment docs.

Copy link
Owner

@reugn reugn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhaijian.

@reugn reugn changed the title Update throttler.go Close the notify channel in throttler Dec 25, 2021
@reugn reugn merged commit a1381da into reugn:master Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants