Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept elements with namespace prefix #4

Merged
merged 1 commit into from
Oct 2, 2016

Conversation

th-we
Copy link
Contributor

@th-we th-we commented Oct 2, 2016

It's generally a good idea not to use name() on elements that are in a namespace because they might have a prefix. This adds a test for lyrics.

@rettinghaus
Copy link
Owner

Nice! Thanks!

@rettinghaus rettinghaus merged commit 8f60d2b into rettinghaus:master Oct 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants