Boyscout and typo fixes - #1985
Open
oliv3r wants to merge 2 commits into
Open
Conversation
No code changes are part of this commit. Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
MediaItem.ExpiresAt was a class-level attribute resolved via LanguageHelper.get_localized_string() at import time. Every other localized display string in the same method (DrmProtected, GeoLockedId, PremiumPaid, HiddenItem) is fetched inline at render time. ExpiresAt was the odd one out, and the inconsistency was not intentional: it serves the same purpose as those strings (a human-readable label shown in the item description) and has no business being cached at class level alongside the LabelEpisode/LabelTvShowTitle constants, which are Kodi InfoLabel API keys and are intentionally plain strings. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
Contributor
Author
|
Also, just letting you know I'm still working on this; but due to personal circumstances had to drop things for a bit. I'll start pushing more stuff again soon :) |
|
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment on it to reset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two small boyscout fixes, one is just two spelling typo's, the other a (I hope/think) simple consistency change.