Fixed: Vault defers PIN creation to first write - #1972
Open
oliv3r wants to merge 1 commit into
Open
Conversation
Vault.__init__ previously triggered the howto dialog and PIN creation flow unconditionally when no application key was present, causing the PIN setup prompt to fire on every channel entry for a fresh install. Introduce a lazy initializer called only by set_setting and set_channel_setting. The constructor now only decrypts an existing key (prompting for the unlock PIN); it stays silent when no key is stored. Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
|
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment on it to reset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vault.init previously triggered the howto dialog and PIN creation flow unconditionally when no application key was present, causing the PIN setup prompt to fire on every channel entry for a fresh install.
Introduce a lazy initializer called only by set_setting and set_channel_setting. The constructor now only decrypts an existing key (prompting for the unlock PIN); it stays silent when no key is stored.
Assisted-by: Claude Sonnet 4.6 noreply@anthropic.com
Signed-off-by: Olliver Schinagl oliver@schinagl.nl