Improved: Lazy-init TextureHandler in ChannelInfo.get_channel() - #1954
Open
oliv3r wants to merge 1 commit into
Open
Improved: Lazy-init TextureHandler in ChannelInfo.get_channel()#1954oliv3r wants to merge 1 commit into
oliv3r wants to merge 1 commit into
Conversation
Collaborator
|
What would be the purpose of this? |
oliv3r
force-pushed
the
lazyinit
branch
2 times, most recently
from
March 28, 2026 13:21
a39d325 to
e02c2fe
Compare
Contributor
Author
|
I ran into test pipeline crashes because of this. Not 100% it is actually still relevant with some refactoring I did; but i'm getting close to push some clean stuff again; so we can re-evaluate there. |
Channel.__init__ calls TextureHandler.instance().get_texture_uri() immediately, so any caller of get_channel() would crash if TextureHandler had not been explicitly set up beforehand. Initializing it lazily inside get_channel() means callers no longer need to know about or manage TextureHandler themselves. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
|
Contributor
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment on it to reset. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Channel.init calls TextureHandler.instance().get_texture_uri() immediately, so any caller of get_channel() would crash if TextureHandler had not been explicitly set up beforehand.
Initializing it lazily inside get_channel() means callers no longer need to know about or manage TextureHandler themselves.