Fix WrapperPlayServerStatistics read on 1.13+ servers - #1560
Open
ramenrrami wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WrapperPlayServerStatisticsstill reads the pre-1.13 format, a map of string keyed statistics. Since 1.13 the packet uses numeric registry ids instead (category id, statistic id and value as VarInts), so constructing the wrapper on a modern server misreads the buffer and throws an IndexOutOfBoundsException (#1491).This PR branches on
ServerVersion.V_1_13likeWrapperPlayServerTabCompletedoes: on 1.13+ the entries are read/written as a list ofStatisticEntry, the legacy map path stays untouched.getStatistics()is now@Nullablesince it is only populated on pre-1.13 servers.Fixes #1491