WIP Avoid mutation during iteration bug in package object lazy open #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
reviewed
May 19, 2025
| val toOpen = deferredOpen.toVector | ||
| for (sym <- toOpen) { | ||
| if (deferredOpen.remove(sym)) | ||
| // CAREFUL -- this can mutate deferredOpen, hence the defensive code here! |
There was a problem hiding this comment.
can it add more symbols to deferredOpen that also need to be opened?
There was a problem hiding this comment.
AFAICT it only removes them
There was a problem hiding this comment.
retronym
force-pushed
the
bug/package-object-deferred
branch
3 times, most recently
from
b26db93 to
d1b5ea3
Compare
Test for edge case with package objects load Avoid mutation-during-iteration during package object initialization
retronym
force-pushed
the
bug/package-object-deferred
branch
from
d1b5ea3 to
4b5ec3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still working on a test case...