Skip to content

Conversation

@OldManYells
Copy link

This PR adds new command /pinv to open and modify a online player inventory directly.

Please review and let me know if this functionality should be placed some other place.

@OldManYells OldManYells changed the title feat: /pinv command to manage player inventory feat: Api to display inventory to remote player Jan 19, 2026
@Garsooon
Copy link
Member

Garsooon commented Jan 20, 2026

While I think this is a cool feature I don't know if features that are traditionally added by most major server eco/moderation plugins should be getting added to the server jar when it can be done via plugins.

Additionally if this does get added, the command should fall under a /poseidon subcommand, see this PR for context.

@OldManYells
Copy link
Author

While I think this is a cool feature I don't know if features that are traditionally added by most major server eco/moderation plugins should be getting added to the server jar when it can be done via plugins.

Additionally if this does get added, the command should fall under a /poseidon subcommand, see this PR for context.

This PR atm only exposes through Bukkit what otherwise is only called by server internal code, the actual feature/command would be added in a plugin or as you mentioned in /poseidon. Not sure if you mean something else or you are referring to a previous commit that also added the command.

@Garsooon
Copy link
Member

Garsooon commented Jan 31, 2026

While I think this is a cool feature I don't know if features that are traditionally added by most major server eco/moderation plugins should be getting added to the server jar when it can be done via plugins.
Additionally if this does get added, the command should fall under a /poseidon subcommand, see this PR for context.

This PR atm only exposes through Bukkit what otherwise is only called by server internal code, the actual feature/command would be added in a plugin or as you mentioned in /poseidon. Not sure if you mean something else or you are referring to a previous commit that also added the command.

Yeah I figured the PR was a draft of some kind going off of it's previous title talking about adding it as a command.
image

@OldManYells
Copy link
Author

@Garsooon how would you like to go about on this?

@Garsooon
Copy link
Member

Up to @RhysB, however when we were talking about it briefly in both forms (api/command) it probably wouldn't be needed since B1.7.3 plugins already can and have accessed inventories using NMS among other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants