Add a trivia game#19
Merged
retrixe merged 24 commits intoretrixe:masterfrom Jul 30, 2021
0xVR:feature/trivia
Merged
Conversation
…into feature/trivia
retrixe
requested changes
Apr 21, 2021
…rivia following code review
retrixe
requested changes
Jul 18, 2021
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
The PR almost looks good, I need to look more closely at the trivia, since that's the most complex part, but this is what I can see right now.
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
requested changes
Jul 26, 2021
retrixe
reviewed
Jul 27, 2021
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
requested changes
Jul 28, 2021
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
Found more potential errors and bugs and stuff that could be cleaned up, and left patches for the constructor changes I suggested.
retrixe
reviewed
Jul 28, 2021
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
requested changes
Jul 29, 2021
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
I think the PR is in pretty good shape now, just need to resolve existing reviews, test and merge.
retrixe
reviewed
Jul 29, 2021
retrixe
reviewed
Jul 29, 2021
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
reviewed
Jul 30, 2021
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
Add medals like so when the game ends.
retrixe
reviewed
Jul 30, 2021
retrixe
reviewed
Jul 30, 2021
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
approved these changes
Jul 30, 2021
Owner
There was a problem hiding this comment.
Alright, everything seems to be well done now!
- We could use fuse.js for answer matching so typos and mistakes would be alright.
- The way trivia lists are distributed is not ideal.
- The flag soup for the command is kinda gross.
But all in all it's good enough to merge now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a fun trivia game to the bot, with customizable settings and many different topics.