Add /suppress#18
Merged
retrixe merged 6 commits intoretrixe:masterfrom Nov 6, 2020
0xVR:feature/suppress
Merged
Conversation
retrixe
requested changes
Oct 5, 2020
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
Not only are there are a lot of stuff that can be fixed, but there is no shortage of duplicate code, I'm only stopping here since the code is littered with too many comments from me. Apply these in batch and check back for more.
retrixe
requested changes
Oct 5, 2020
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
Remove even more redundant code that could be common.
retrixe
requested changes
Oct 5, 2020
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
Okay, we're done here with code cleanup, it looks good to me after these changes now.
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
These casts are no longer needed with Eris 0.14.0.
retrixe
approved these changes
Nov 6, 2020
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
It's still a bit unsightly, but okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows anyone with Manage Messages to suppress (or unsuppress!) the embeds on a message.
Note: The code is slightly messy due to missing typings. Also, it makes use of the request handler to avoid being hit with a DiscordRESTError [50005]